lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH v7 19/23] drm/mediatek: Return error if MDP RDMA failed to enable the clock
    Date
    Hi, Hsiao-chien:

    On Fri, 2023-10-06 at 15:38 +0800, Hsiao Chien Sung wrote:
    > Return the result of clk_prepare_enable() instead of
    > always returns 0.

    Reviewed-by: CK Hu <ck.hu@mediatek.com>

    >
    > Fixes: f8946e2b6bb2 ("drm/mediatek: Add display MDP RDMA support for
    > MT8195")
    >
    > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
    > ---
    > drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
    > b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
    > index c3adaeefd551..c7233d0ac210 100644
    > --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
    > +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
    > @@ -246,8 +246,7 @@ int mtk_mdp_rdma_clk_enable(struct device *dev)
    > {
    > struct mtk_mdp_rdma *rdma = dev_get_drvdata(dev);
    >
    > - clk_prepare_enable(rdma->clk);
    > - return 0;
    > + return clk_prepare_enable(rdma->clk);
    > }
    >
    > void mtk_mdp_rdma_clk_disable(struct device *dev)
    \
     
     \ /
      Last update: 2023-10-06 11:08    [W:4.158 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site