lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 15/18] x86/sgx: Prepare for multiple LRUs
    Date
    From
    On Thu, 05 Oct 2023 07:30:46 -0500, Huang, Kai <kai.huang@intel.com> wrote:

    > On Fri, 2023-09-22 at 20:06 -0700, Haitao Huang wrote:
    >> +static inline struct sgx_epc_lru_lists *sgx_lru_lists(struct
    >> sgx_epc_page *epc_page)
    >> +{
    >> + return &sgx_global_lru;
    >> +}
    >> +
    >> +static inline bool sgx_can_reclaim(void)
    >> +{
    >> + return !list_empty(&sgx_global_lru.reclaimable);
    >> +}
    >> +
    >
    > Shouldn't sgx_can_reclaim() also take a 'struct sgx_epc_lru_lists *'?
    >
    > I thought we also need to check whether a cgroup's LRU lists can be
    > reclaimed?

    This is only used to check if any pages reclaimable at the top level in
    this file. Later sgx_epc_cgroup_lru_empty(NULL) is used in this function
    to recursively check all cgroups starting from the root.

    Haitao

    \
     
     \ /
      Last update: 2023-10-05 21:33    [W:4.780 / U:1.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site