lkml.org 
[lkml]   [2023]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node
Date
Am Donnerstag, 5. Oktober 2023, 17:39:18 CEST schrieb Benjamin Gaignard:
>
> Le 05/10/2023 à 17:30, Heiko Stuebner a écrit :
> > Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel:
> >> Hi,
> >>
> >> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote:
> >>> Add node for AV1 video decoder.
> >>>
> >>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >> No need for my SoB. Instead have this one:
> >>
> >> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >>
> >> Also worth mentioning, that this Patch needs one small fix in the DT
> >> binding (adding "resets") and one small fix in the driver for out of
> >> the box AV1 support:
> >>
> >> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@collabora.com/
> >> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@collabora.com/
> > additionally the node name should be generic.
> > The phandle can of course be av1d but the node
> > name itself needs a change.
>
> Does "video-codec-av1@fdc70000" sound good for you ?

Nope ... please go with
video-codec@fdc...
I.e. see the other Rockchip soc dtsi for reference.


Thanks
Heiko


\
 
 \ /
  Last update: 2023-10-05 18:22    [W:0.044 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site