Messages in this thread Patch in this message | | | From | Geert Uytterhoeven <> | Date | Thu, 5 Oct 2023 09:10:39 +0200 | Subject | Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX |
| |
Hi Ralph,
On Wed, Oct 4, 2023 at 10:00 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote: > Enable pin muxing (eg. programmable function), so that the RZN1 GPIO > pins will be configured as specified by the pinmux in the DTS. > > This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS, > however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
You missed the first character of the commit ID.
> since the rzn1 driver does not call any of the generic pinmux functions. > > Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>
Fixes: 1308fb4e4eae14e6 ("pinctrl: rzn1: Do not select GENERIC_PIN{CTRL_GROUPS,MUX_FUNCTIONS}")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-pinctrl-fixes-for-v6.6...
> --- a/drivers/pinctrl/renesas/Kconfig > +++ b/drivers/pinctrl/renesas/Kconfig > @@ -234,6 +234,7 @@ config PINCTRL_RZN1 > bool "pin control support for RZ/N1" > depends on OF > depends on ARCH_RZN1 || COMPILE_TEST > + select PINMUX > select GENERIC_PINCONF
... with alphabetical sort order restored. No need to resend.
> help > This selects pinctrl driver for Renesas RZ/N1 devices.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |