lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: microchip: lan743x: improve throughput with rx timestamp config
On Tue, 26 Sep 2023 21:26:58 +0530 Vishvambar Panth S wrote:
> + netif_warn(adapter, drv, adapter->netdev,
> + "rx timestamp = %d is not supported\n",
> + rx_filter);

I addition to Jake's comments please also drop this warning.

> + return -EINVAL;

And make sure this is the correct return code.
I thought -ERANGE was more appropriate here, but I could be wrong.

\
 
 \ /
  Last update: 2023-10-04 20:01    [W:0.076 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site