lkml.org 
[lkml]   [2023]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 29/36] pinctrl: st: use new pinctrl GPIO helpers
    From


    On 10/3/23 16:51, Bartosz Golaszewski wrote:
    > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    >
    > Replace the pinctrl helpers taking the global GPIO number as argument
    > with the improved variants that instead take a pointer to the GPIO chip
    > and the controller-relative offset.
    >
    > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    > ---
    > drivers/pinctrl/pinctrl-st.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
    > index c1f36b164ea5..ec763572ab3e 100644
    > --- a/drivers/pinctrl/pinctrl-st.c
    > +++ b/drivers/pinctrl/pinctrl-st.c
    > @@ -719,7 +719,7 @@ static void st_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
    >
    > static int st_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
    > {
    > - pinctrl_gpio_direction_input(chip->base + offset);
    > + pinctrl_gpio_direction_input_new(chip, offset);
    >
    > return 0;
    > }
    > @@ -730,7 +730,7 @@ static int st_gpio_direction_output(struct gpio_chip *chip,
    > struct st_gpio_bank *bank = gpiochip_get_data(chip);
    >
    > __st_gpio_set(bank, offset, value);
    > - pinctrl_gpio_direction_output(chip->base + offset);
    > + pinctrl_gpio_direction_output_new(chip, offset);
    >
    > return 0;
    > }

    Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

    Thanks
    Patrice

    \
     
     \ /
      Last update: 2023-10-04 16:42    [W:4.352 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site