Messages in this thread | | | Date | Wed, 4 Oct 2023 11:31:26 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] sched: Update comment of try_invoke_on_locked_down_task() |
| |
* Zhang Qiao <zhangqiao22@huawei.com> wrote:
> Since commit 9b3c4ab3045e ("sched,rcu: Rework > try_invoke_on_locked_down_task()") renamed > try_invoke_on_locked_down_task() to task_call_func(). > Now, update some comment about it. > > Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com> > --- > kernel/sched/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 0d18c3969f90..540ac33ddb80 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4186,7 +4186,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) > * Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in > * __schedule(). See the comment for smp_mb__after_spinlock(). > * > - * A similar smb_rmb() lives in try_invoke_on_locked_down_task(). > + * A similar smb_rmb() lives in task_call_func().
Except the matching smp_rmb() doesn't live in task_call_func() anymore, so you now turned a stale comment into a misleading one ...
And how about fixing the obvious 'smb/smp' typo as well?
Thanks,
Ingo
| |