Messages in this thread | | | From | Jeffery Miller <> | Date | Wed, 4 Oct 2023 19:13:24 -0500 | Subject | Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode |
| |
Dmitry,
On Wed, Oct 4, 2023 at 9:11 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > In fact, now that I think about it more, we should rework the original > patch that added the delay, so that we do not wait these 30 msec in the > "fast" reconnect handler. It turns out your original approach was > better, but we should not be using retries, but rather the existing > reset_delay_ms already defined in rmi platform data. I would appreciate > if you try the draft patch at the end of this email (to be applied after > reverting your original one adding the delay in psmouse-smbus.c).
I tested the draft patch and it works. I did revert the previous delay patch while testing it.
> > I think we need a similar change in synaptics.c as that one also can > fall back to PS/2 mode. > Ah, good point, yes it does appear this needs to be done as well. I have tested and will post an new version of the patch to include the fix in synaptics.c as well.
Thanks, Jeff
| |