Messages in this thread | | | From | Rob Herring <> | Date | Tue, 31 Oct 2023 11:34:12 -0500 | Subject | Re: [RESEND PATCH] opp: ti: Use device_get_match_data() |
| |
On Mon, Oct 30, 2023 at 10:45 PM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Hmm, somehow I didn't receive the direct mail last time to my Linaro account > (alias of kernel.org). I do see the message being posted to LKML though.
That was an issue on my side.
> > On 30-10-23, 08:54, Rob Herring wrote: > > Isn't it is compulsory to add some details in the commit log ?
Sigh, I missed adding it on this one. It should be:
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers.
As this driver only does DT based matching, of_match_device() will never return NULL if we've gotten to probe(). Therefore, the NULL check and error return for it can be dropped.
Will fix and repost.
Rob
| |