lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v14 16/56] media: atomisp: Use vb2_get_buffer() instead of directly access to buffers array
    Date
    Use vb2_get_buffer() instead of direct access to the vb2_queue bufs array.
    This allows us to change the type of the bufs in the future.
    No need to check the result of vb2_get_buffer, vb2_ioctl_dqbuf() already
    checked that it is valid.

    Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    CC: Mauro Carvalho Chehab <mchehab@kernel.org>
    CC: Sakari Ailus <sakari.ailus@linux.intel.com>
    ---
    drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
    index a8e4779d007f..a8a964b2f1a8 100644
    --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
    +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
    @@ -1059,7 +1059,7 @@ static int atomisp_dqbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer
    if (ret)
    return ret;

    - vb = pipe->vb_queue.bufs[buf->index];
    + vb = vb2_get_buffer(&pipe->vb_queue, buf->index);
    frame = vb_to_frame(vb);

    buf->reserved = asd->frame_status[buf->index];
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-10-31 17:34    [W:5.787 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site