lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v14 06/56] media: videobuf2: Remove duplicated index vs q->num_buffers check
    Date
    vb2_get_buffer() already checks if the requested index is valid.
    Stop duplicating this kind of check everywhere.

    Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
    ---
    drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
    index 2ffb097bf00a..c6ebc8d2c537 100644
    --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
    +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
    @@ -823,10 +823,6 @@ int vb2_qbuf(struct vb2_queue *q, struct media_device *mdev,
    return -EBUSY;
    }

    - if (b->index >= q->num_buffers) {
    - dprintk(q, 1, "buffer index out of range\n");
    - return -EINVAL;
    - }
    vb = vb2_get_buffer(q, b->index);
    if (!vb) {
    dprintk(q, 1, "can't find the requested buffer %u\n", b->index);
    @@ -898,10 +894,6 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
    {
    struct vb2_buffer *vb;

    - if (eb->index >= q->num_buffers) {
    - dprintk(q, 1, "buffer index out of range\n");
    - return -EINVAL;
    - }
    vb = vb2_get_buffer(q, eb->index);
    if (!vb) {
    dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-10-31 17:32    [W:4.116 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site