Messages in this thread | | | Date | Tue, 31 Oct 2023 12:22:47 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case |
| |
On Mon, Oct 30, 2023 at 11:14:11PM +0200, Raag Jadav wrote: > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > > iWhen ->pin_config_set() is called from the GPIO library (assumed > > GpioIo() ACPI resource), the argument can be 1, when, for example, > > PullDefault is provided. In such case we supply sane default in > > the driver. Move that default assingment to a switch-case, so > > it will be consolidated in one place. > > Looks good.
Thank you for review. Can you give your Rb tag then?
> iWhen -> When
I'll fix it locally.
-- With Best Regards, Andy Shevchenko
| |