lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH v7 06/11] KVM: xen: allow shared_info to be mapped by fixed HVA
From
On Mon, Oct 02, 2023, Paul Durrant wrote:
> NOTE: The change of the kvm_xen_hvm_attr shared_info from struct to union
> is technically an ABI change but it's entirely compatible with
> existing users.

It's not an ABI change, is it? Userspace that picks up the new header might generate
different code on a rebuild, but the actual ABI is unchanged, no?

> @@ -684,6 +692,14 @@ int kvm_xen_hvm_get_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
> r = 0;
> break;
>
> + case KVM_XEN_ATTR_TYPE_SHARED_INFO_HVA:
> + if (kvm->arch.xen.shinfo_cache.active)

As requested in previous patches, please explicitly check that the cache is in
the right "mode".

> + data->u.shared_info.hva = kvm_gpc_hva(&kvm->arch.xen.shinfo_cache);
> + else
> + data->u.shared_info.hva = 0;
> + r = 0;
> + break;

\
 
 \ /
  Last update: 2023-11-01 00:53    [W:0.168 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site