lkml.org 
[lkml]   [2023]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
On Mon, Oct 30, 2023 at 01:22:02PM -0700, Suren Baghdasaryan wrote:
> > > +static int adjust_page_size(void)
> > > +{
> > > + page_size = default_huge_page_size();
> >
> > This is hacky too, currently page_size is the real page_size backing the
> > memory.
> >
> > To make thp test simple, maybe just add one more test to MOVE a large chunk
> > to replace the thp test, which may contain a few thps? It also doesn't
> > need to be fault based.
>
> Sorry, I didn't get your suggestion. Could you please clarify? Which
> thp test are you referring to?

The new "move-pmd" test.

I meant maybe it makes sense to have one separate MOVE test for when one
ioctl(MOVE) covers a large range which can cover some thps. Then that will
trigger thp paths. Assuming the fault paths are already covered in the
generic "move" test.

Thanks,

--
Peter Xu

\
 
 \ /
  Last update: 2023-10-30 21:36    [W:0.184 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site