Looks good:Reviewed-by: Christoph Hellwig <hch@lst.de>> Personally I prefer v1. Pick the one you prefer :)I think we should be consistent with one style or another in agiven function. Otherwise I wouldn't even have mentioned it.