lkml.org 
[lkml]   [2023]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net-next v2 9/9] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY
    From
    On 30/10/2023 14:16, Parthiban.Veerasooran@microchip.com wrote:
    > Hi Krzysztof,
    >
    > On 24/10/23 1:33 pm, Krzysztof Kozlowski wrote:
    >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
    >>
    >> On 23/10/2023 17:46, Parthiban Veerasooran wrote:
    >>> Add DT bindings for Microchip's LAN865X 10BASE-T1S MACPHY. The LAN8650/1
    >>> combines a Media Access Controller (MAC) and an Ethernet PHY to enable
    >>> 10BASE‑T1S networks. The Ethernet Media Access Controller (MAC) module
    >>> implements a 10 Mbps half duplex Ethernet MAC, compatible with the IEEE
    >>> 802.3 standard and a 10BASE-T1S physical layer transceiver integrated
    >>> into the LAN8650/1. The communication between the Host and the MAC-PHY is
    >>> specified in the OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6).
    >>
    >> It does not look like you tested the bindings, at least after quick
    >> look. Please run `make dt_binding_check` (see
    >> Documentation/devicetree/bindings/writing-schema.rst for instructions).
    >> Maybe you need to update your dtschema and yamllint.
    > Sorry, somehow I missed doing this check. Will fix this in the next
    > revision.

    Please also build your driver.

    >>
    >>>
    >>> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
    >>> ---
    >>> .../bindings/net/microchip,lan865x.yaml | 101 ++++++++++++++++++
    >>> MAINTAINERS | 1 +
    >>> 2 files changed, 102 insertions(+)
    >>> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml
    >>>
    >>> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml
    >>> new file mode 100644
    >>> index 000000000000..974622dd6846
    >>> --- /dev/null
    >>> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml
    >>> @@ -0,0 +1,101 @@
    >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    >>> +%YAML 1.2
    >>> +---
    >>> +$id: http://devicetree.org/schemas/net/microchip,lan865x.yaml#
    >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
    >>> +
    >>> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers
    >>> +
    >>> +maintainers:
    >>> + - Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
    >>> +
    >>> +description:
    >>> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet
    >>> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller
    >>> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible
    >>> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver
    >>> + integrated into the LAN8650/1. The communication between the Host and
    >>> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial
    >>> + Interface (TC6).
    >>> +
    >>> + Specifications about the LAN8650/1 can be found at:
    >>> + https://www.microchip.com/en-us/product/lan8650
    >>> +
    >>> +allOf:
    >>> + - $ref: ethernet-controller.yaml#
    >>> +
    >>> +properties:
    >>> + compatible:
    >>> + const: microchip,lan865x
    >>
    >> No wildcards in compatibles.
    > Ah ok missed it. So it will become like below isn't it?
    >
    > properties:
    > compatible:
    > enum:
    > - microchip,lan8650
    > - microchip,lan8651

    Rather enum for lan8650 and items for lan8651 with fallback. Aren't they
    compatible, since you wanted to use wildcard?


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-10-30 15:45    [W:4.249 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site