Messages in this thread | | | Date | Mon, 30 Oct 2023 13:39:27 +0100 | Subject | Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative | From | Juergen Gross <> |
| |
On 25.10.23 12:34, Borislav Petkov wrote: > On Thu, Oct 19, 2023 at 11:15:16AM +0200, Juergen Gross wrote: >> +/* Low-level backend functions usable from alternative code replacements. */ >> +DEFINE_ASM_FUNC(x86_nop, "", .entry.text); >> +EXPORT_SYMBOL_GPL(x86_nop); > > This is all x86 code so you don't really need the "x86_" prefix - "nop" > is perfectly fine. > >> +noinstr void x86_BUG(void) >> +{ >> + BUG(); >> +} >> +EXPORT_SYMBOL_GPL(x86_BUG); > > That export is needed for? > > Paravirt stuff in modules? > > It builds here without it - I guess I need to do an allmodconfig. >
Turns out it is needed after all. With patch 4 applied I get:
ERROR: modpost: "BUG_func" [arch/x86/events/amd/power.ko] undefined! ERROR: modpost: "BUG_func" [arch/x86/kernel/cpu/mce/mce-inject.ko] undefined! ERROR: modpost: "BUG_func" [arch/x86/kernel/cpuid.ko] undefined! ERROR: modpost: "BUG_func" [arch/x86/kvm/kvm.ko] undefined! ERROR: modpost: "BUG_func" [arch/x86/kvm/kvm-intel.ko] undefined! ERROR: modpost: "BUG_func" [arch/x86/kvm/kvm-amd.ko] undefined! ERROR: modpost: "BUG_func" [fs/nfsd/nfsd.ko] undefined! ERROR: modpost: "BUG_func" [crypto/aes_ti.ko] undefined! ERROR: modpost: "BUG_func" [drivers/video/fbdev/uvesafb.ko] undefined! ERROR: modpost: "BUG_func" [drivers/video/vgastate.ko] undefined!
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |