lkml.org 
[lkml]   [2023]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/7] ASoC: codecs: wcd938x: drop bogus bind error handling
    Date
    Drop the bogus error handling for a soundwire device backcast during
    bind() that cannot fail.

    Fixes: 16572522aece ("ASoC: codecs: wcd938x-sdw: add SoundWire driver")
    Cc: stable@vger.kernel.org # 5.14
    Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    ---
    sound/soc/codecs/wcd938x.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
    index a3c680661377..cf1eaf678fc2 100644
    --- a/sound/soc/codecs/wcd938x.c
    +++ b/sound/soc/codecs/wcd938x.c
    @@ -3448,10 +3448,6 @@ static int wcd938x_bind(struct device *dev)
    wcd938x->sdw_priv[AIF1_CAP] = dev_get_drvdata(wcd938x->txdev);
    wcd938x->sdw_priv[AIF1_CAP]->wcd938x = wcd938x;
    wcd938x->tx_sdw_dev = dev_to_sdw_dev(wcd938x->txdev);
    - if (!wcd938x->tx_sdw_dev) {
    - dev_err(dev, "could not get txslave with matching of dev\n");
    - return -EINVAL;
    - }

    /* As TX is main CSR reg interface, which should not be suspended first.
    * expicilty add the dependency link */
    --
    2.41.0
    \
     
     \ /
      Last update: 2023-10-03 17:59    [W:6.658 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site