Messages in this thread | | | Date | Tue, 3 Oct 2023 18:57:04 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v2 4/5] dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup |
| |
On Tue, Oct 03, 2023 at 05:34:32PM +0200, Köry Maincent wrote: > On Tue, 3 Oct 2023 18:20:23 +0300 > Serge Semin <fancer.lancer@gmail.com> wrote: > > > On Tue, Oct 03, 2023 at 02:15:42PM +0200, Köry Maincent wrote: > > > From: Kory Maincent <kory.maincent@bootlin.com> > > > > > > The Linked list element and pointer are not stored in the same memory as > > > the HDMA controller register. If the doorbell register is toggled before > > > the full write of the linked list a race condition error can appears. > > > In remote setup we can only use a readl to the memory to assured the full > > > write has occurred. > > > > > > Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > > --- > > > > > > Changes in v2: > > > - Move the sync read in a function. > > > - Add commments > > > > Note you need to resubmit the entire series if any of its part has > > changed. So please add these patches to your patchset (in place of the > > 4/5 and 5/5 patches I commented) and resend it as v3. > > Alright. > Should I wait for Cai's response for patch 1/5 before sending v3. He seems to > never having woken up in our discussions.
Ok. Let's wait for Cai for sometime. We are in the middle of the dev-cycle anyway so no reason to rush.
-Serge(y)
| |