Messages in this thread | | | Subject | Re: [PATCH net v2] ethtool: plca: fix plca enable data type while parsing the value | From | patchwork-bot+netdevbpf@kernel ... | Date | Tue, 03 Oct 2023 14:40:28 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Fri, 8 Sep 2023 10:15:48 +0530 you wrote: > The ETHTOOL_A_PLCA_ENABLED data type is u8. But while parsing the > value from the attribute, nla_get_u32() is used in the plca_update_sint() > function instead of nla_get_u8(). So plca_cfg.enabled variable is updated > with some garbage value instead of 0 or 1 and always enables plca even > though plca is disabled through ethtool application. This bug has been > fixed by parsing the values based on the attributes type in the policy. > > [...]
Here is the summary with links: - [net,v2] ethtool: plca: fix plca enable data type while parsing the value https://git.kernel.org/netdev/net/c/8957261cd814
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |