Messages in this thread | | | From | Jeffery Miller <> | Date | Tue, 3 Oct 2023 20:08:32 -0500 | Subject | Re: [regression] Resume broken on T14s Gen1 (AMD) due to "Input: psmouse - add delay when deactivating for SMBus mode" |
| |
On Tue, Oct 3, 2023 at 2:30 AM Thorsten Leemhuis <linux@leemhuis.info> wrote: > > This didn't print anything on resume, so `psmouse->private` apparently > is set. >
Thank you for reporting this and providing the information!
need_deactivate is never being set on the smbdev struct since it's elantouch. On this machine SMBus is not used so it falls back to PS/2 mode. When this occurs the psmouse->private pointer is being replaced but psmouse_smbus_reconnect is still being called on resume expecting smbdev. That explains why when it is setup needs_deactivate is false, but on resume it has somehow changed to true.
I've submitted a fix for this at https://lore.kernel.org/all/20231004005729.3943515-1-jefferymiller@google.com/ and it should resolve this issue for you.
Thanks, Jeff
| |