Messages in this thread | | | From | Paweł Dembicki <> | Date | Tue, 3 Oct 2023 23:50:11 +0200 | Subject | Re: [PATCH net-next v3 2/8] net: dsa: vsc73xx: convert to PHYLINK |
| |
wt., 3 paź 2023 o 23:32 Andrew Lunn <andrew@lunn.ch> napisał(a): > > > I plan to make rgmii delays configurable from the device tree. Should I? > > a. switch to phy_interface_is_rgmii in the current patch? > > b. add another patch in this series? > > c. wait with change to phy_interface_is_rgmii for patch with rgmii > > delays configuration? > > Do you actually need this feature? Does the PHY you are using already > support fine tuning of the delays? >
After Vladimir answer I know that it should be a separate change. I need it for MAC <-> switch connection, the rgmii port connected to the cpu. At this moment, rgmii delays are hardcoded in vsc73xx_setup and it should be tunable for the p2020rdb board. I plan to work on it after the driver becomes usable.
| |