lkml.org 
[lkml]   [2023]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] hyperv: rndis_filter needs to select NLS
    Date
    From: Randy Dunlap <rdunlap@infradead.org> Sent: Friday, September 29, 2023 7:33 PM
    >

    Patches for this driver usually use the subject prefix "hv_netvsc: ", not "hyperv".
    Other than that minor tweak,

    Reviewed-by: Michael Kelley <mikelley@microsoft.com>

    > rndis_filter uses utf8s_to_utf16s() which is provided by setting
    > NLS, so select NLS to fix the build error:
    >
    > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined!
    >
    > Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests")
    > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    > Cc: Haiyang Zhang <haiyangz@microsoft.com>
    > Cc: K. Y. Srinivasan <kys@microsoft.com>
    > Cc: Wei Liu <wei.liu@kernel.org>
    > Cc: Dexuan Cui <decui@microsoft.com>
    > Cc: linux-hyperv@vger.kernel.org
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: Eric Dumazet <edumazet@google.com>
    > Cc: Jakub Kicinski <kuba@kernel.org>
    > Cc: Paolo Abeni <pabeni@redhat.com>
    > Cc: netdev@vger.kernel.org
    > ---
    > drivers/net/hyperv/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff -- a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
    > --- a/drivers/net/hyperv/Kconfig
    > +++ b/drivers/net/hyperv/Kconfig
    > @@ -3,5 +3,6 @@ config HYPERV_NET
    > tristate "Microsoft Hyper-V virtual network driver"
    > depends on HYPERV
    > select UCS2_STRING
    > + select NLS
    > help
    > Select this option to enable the Hyper-V virtual network driver.

    \
     
     \ /
      Last update: 2023-10-03 19:13    [W:7.963 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site