Messages in this thread | | | Date | Sun, 29 Oct 2023 09:14:08 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] eventfs: Test for ei->is_freed when accessing ei->dentry |
| |
On Sun, 29 Oct 2023 12:31:54 +0530 Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> Following build errors have been noticed. > > fs/tracefs/event_inode.c:348:1: error: return type defaults to 'int' > [-Werror=implicit-int] > 348 | create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei, > | ^~~~~~~~~~~~~~~~~ > In file included from include/uapi/linux/posix_types.h:5, > from include/uapi/linux/types.h:14, > from include/linux/types.h:6, > from include/linux/kasan-checks.h:5, > from include/asm-generic/rwonce.h:26, > from ./arch/x86/include/generated/asm/rwonce.h:1,
This patch passed all my tests, I have no idea how the above happened. The "return type defaults to int" tells me the "static struct dentry *" part of the patch may have been clipped.
Are you sure it was applied correctly? Perhaps check out the branch I have and let me know if you get the same errors.
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace/core
-- Steve
| |