Messages in this thread | | | Subject | Re: [PATCH v2] lockdep: add lockdep_cleanup_dead_cpu() | From | David Woodhouse <> | Date | Sun, 29 Oct 2023 17:47:52 +0000 |
| |
On Sun, 2023-10-29 at 18:33 +0100, Thomas Gleixner wrote: > On Sat, Oct 28 2023 at 20:24, David Woodhouse wrote: > > @@ -24,12 +24,16 @@ > > extern void lockdep_hardirqs_on_prepare(void); > > extern void lockdep_hardirqs_on(unsigned long ip); > > extern void lockdep_hardirqs_off(unsigned long ip); > > + extern void lockdep_cleanup_dead_cpu(unsigned int cpu, > > + struct task_struct *idle); > > Lacks a forward declaration of 'struct task_struct' >
Apparently so; I thought that was fairly much ubiquitous. Was debating spamming you with a v3 in the space of as many days, or perhaps revisiting my decision to *pass* the idle task out of kernel/cpu.c.
We could always shift the declaration of idle_thread_get() out to linux/smpboot.h and let the lockdep code call it directly. You already reviewed my patch to do that, although it was dropped in the end.
https://lore.kernel.org/lkml/20230321194008.785922-2-usama.arif@bytedance.com/ [unhandled content-type:application/pkcs7-signature] | |