Messages in this thread | | | Date | Sat, 28 Oct 2023 11:10:28 +0200 | Subject | Re: [PATCH v2 2/9] dt-bindings: mailbox: Add property for CMDQ secure driver | From | Krzysztof Kozlowski <> |
| |
On 24/10/2023 18:37, Jason-JH Lin (林睿祥) wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Mon, 2023-10-23 at 09:49 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 23/10/2023 06:37, Jason-JH.Lin wrote: >>> Add mboxes to define a GCE loopping thread as a secure irq handler. >>> Add mediatek,gce-events to define a GCE event siganl sent from CMDQ >>> TA driver in secure world as a secure irq. >>> >>> These 2 properties are required for CMDQ secure driver. >>> >>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> >>> --- >>> .../bindings/mailbox/mediatek,gce-mailbox.yaml | 10 >> ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git >> a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml >> b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml >>> index cef9d7601398..65fb93bb53b6 100644 >>> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce- >> mailbox.yaml >>> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce- >> mailbox.yaml >>> @@ -49,6 +49,16 @@ properties: >>> items: >>> - const: gce >>> >>> + mboxes: >>> + maxItems: 1 >>> + >>> + mediatek,gce-events: >>> + description: >>> + The event id which is mapping to the specific hardware event >> signal >>> + to gce. The event id is defined in the gce header >>> + include/dt-bindings/gce/<chip>-gce.h of each chips. >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >> >> Nothing improved. >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my > > Sorry, I didn't find your comments in the previous patch here: > > https://patchwork.kernel.org/project/linux-mediatek/patch/20230918192204.32263-2-jason-jh.lin@mediatek.com/ > > Could you please comment again? > Thank you very much.
Please implement Rob's feedback. > > > And I do see Rob's comment, so I sync the mediatek,gce-events property > definition from other yaml where used this property. > > Should I also modify the definition of mediatek,gce-events property to > reference to mediatek,gce-mailbox.yaml for other yaml?
You need single definition in one of the bindings or in shared bindings. Depends on the users of this property.
Best regards, Krzysztof
| |