Messages in this thread | | | Date | Sat, 28 Oct 2023 21:36:05 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase |
| |
> > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip, > > the regmap-irq code must be able to perform I2C transactions during > > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must > > be suspended/resumed during the NOIRQ phase. > > > > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> > > I think this patch has failed to receive some comments, I'll go > ahead and give it my blessing: > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
It needs to be rebased on top of 0ad93449b043 ("i2c: ocores: Remove #ifdef guards for PM related functions"), though. This series did clean this up for the whole subsystem. It also introduced using pm_sleep_ptr which probably was missing here?
[unhandled content-type:application/pgp-signature]
| |