Messages in this thread | | | Date | Fri, 27 Oct 2023 09:18:57 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2] iio: sx9324: avoid copying property strings |
| |
On Thu, Oct 26, 2023 at 11:53:28PM +0000, Justin Stitt wrote: > We're doing some needless string copies when trying to assign the proper > `prop` string. We can make `prop` a const char* and simply assign to > string literals. > > For the case where a format string is used, let's allocate some memory > via kasprintf() and point prop to it. > > This also cleans up some deprecated strncpy() uses [1]. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
Looks like a reasonable way to go.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |