Messages in this thread | | | From | Miklos Szeredi <> | Date | Fri, 27 Oct 2023 16:05:27 +0200 | Subject | Re: [PATCH v2] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT" |
| |
On Fri, Oct 27, 2023 at 3:39 PM André Draszik <andre.draszik@linaro.org> wrote: > > On Fri, 2023-10-27 at 15:24 +0200, Miklos Szeredi wrote: > > On Fri, Oct 27, 2023 at 3:14 PM André Draszik > > <andre.draszik@linaro.org> wrote: > > > > > The patch in question has broken all users that use the higher > > > flags > > > and that don't use your version of libfuse, not just Android. > > > You're > > > filtering them out now when you didn't at the time that those > > > ('official) high flags were added. There are a couple more high > > > flags > > > than just the one that Android added. > > > > Okay. Where are all those users? > > That's not the point. The point is the kernel<->user API has rendered > them too non-working.
It is a very important point. A theoretical bug isn't a regression. Nor is a broken test case BTW.
Please read section 'What is a "regression" and what is the "no regressions rule"?' in Documentation/admin-guide/reporting-regressions.rst.
Thanks, Miklos
| |