Messages in this thread | | | Date | Fri, 27 Oct 2023 08:20:13 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA |
| |
On Fri, Oct 27, 2023 at 09:14:17AM +0000, Zhang, Tina wrote: > > > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote: > > > > From: Jason Gunthorpe <jgg@nvidia.com> > > > > > > > > Linus suggested that the kconfig here is confusing: > > > > > > While this patch looks decent to me, you forgot to Cc Linus on it. In > > > general, given that it touches a couple of core files, I'd like to > > > wait for some more people to have a look at it and not rushing anything in. > > Make sense. I'll CC Linus. Comments are welcome.
> Can we separate this patch? I'm thinking about CC more people for > review. At least, we need to CC all the reviewers of > https://lore.kernel.org/all/20230506133134.1492395-1-jacob.jun.pan@linux.intel.com/ > to this patch. So, it seems more reasonable to separate this > patch. What do you think?
I think that makes sense, let's go ahead with the rest of the SVA series and we can do this next cycle. Bikeshedding config names isn't really critical.
Jason
| |