lkml.org 
[lkml]   [2023]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] tty: n_gsm: add copyright Siemens Mobility GmbH
On Fri, Oct 27, 2023 at 07:39:03AM +0200, D. Starke wrote:
> From: Daniel Starke <daniel.starke@siemens.com>
>
> More than 1/3 of the n_gsm code has been contributed by us in the last
> 1.5 years, completing conformance with the standard and stabilizing the
> driver:
> - added UI (unnumbered information) frame support
> - added PN (parameter negotiation) message handling and function support
> - added optional keep-alive control link supervision via test messages
> - added TIOCM_OUT1 and TIOCM_OUT2 to allow responder to operate as modem
> - added TIOCMIWAIT support on virtual ttys
> - added additional ioctls and parameters to configure the new functions
> - added overall locking mechanism to avoid data race conditions
> - added outgoing data flow to decouple physical from virtual tty handling
> for better performance and to avoid dead-locks
> - fixed advanced option mode implementation
> - fixed convergence layer type 2 implementation
> - fixed handling of CLD (multiplexer close down) messages
> - fixed broken muxer close down procedure
> - and many more bug fixes
>
> With this most of our initial RFC has been implemented. It gives the driver
> a quality boost unseen in the decade before.
>
> Add a copyright notice to the n_gsm files to highlight this contribution.
>
> Link: https://lore.kernel.org/all/20220225080758.2869-1-daniel.starke@siemens.com/
> Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
> ---
> drivers/tty/n_gsm.c | 1 +
> include/uapi/linux/gsmmux.h | 1 +
> 2 files changed, 2 insertions(+)

Nit, you didn't include what changed from v1 below the --- line.

I'll take this now, but be more careful in the future.

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-10-27 09:22    [W:0.093 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site