Messages in this thread | | | Date | Fri, 27 Oct 2023 13:04:30 -0700 | From | Dan Williams <> | Subject | RE: [PATCH v12 02/20] cxl/core/regs: Rename @dev to @host in struct cxl_register_map |
| |
Robert Richter wrote: > The primary role of @dev is to host the mappings for devm operations. > @dev is too ambiguous as a name. I.e. when does @dev refer to the > 'struct device *' instance that the registers belong, and when does > @dev refer to the 'struct device *' instance hosting the mapping for > devm operations? > > Clarify the role of @dev in cxl_register_map by renaming it to @host. > Also, rename local variables to 'host' where map->host is used. > > Add Fixes: tag as the fix in the next patch depends on this change.
I tend to not add Fixes tags where they are not needed. When the next patch fails to backport automatically we will get involved to send the full backport set. In fact I prefer that as a checkpoint to review the backport.
Otherwise, looks good to me.
| |