Messages in this thread | | | Date | Fri, 27 Oct 2023 20:31:02 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 5/5] net: bcmgenet: Interrogate PHY for WAKE_FILTER programming |
| |
> It does seem like an acceptable compromise here, and perhaps being > driver specific is ok, since this does depend a lot on the individual > device support, thus broadly applying this across all drivers could be > problematic.
The Marvell PHYs have a similar capability. Its actually more feature rich. It allows upto 8 matches, each being of up to 128 bytes, and you can enable/disable each byte within the 128 bytes. This would in fact be better for Florian's use case, since it could match deeper into the frame and reduce the false positive. But its a Marvell device...
My real point is, other hardware does have similar capabilities. Its unclear if anybody else will ever actually need it, but we should try to avoid a one device solution.
Andrew
| |