lkml.org 
[lkml]   [2023]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v13 24/35] KVM: selftests: Drop unused kvm_userspace_memory_region_find() helper
    From
    Drop kvm_userspace_memory_region_find(), it's unused and a terrible API
    (probably why it's unused). If anything outside of kvm_util.c needs to
    get at the memslot, userspace_mem_region_find() can be exposed to give
    others full access to all memory region/slot information.

    Signed-off-by: Sean Christopherson <seanjc@google.com>
    ---
    .../selftests/kvm/include/kvm_util_base.h | 4 ---
    tools/testing/selftests/kvm/lib/kvm_util.c | 29 -------------------
    2 files changed, 33 deletions(-)

    diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h
    index a18db6a7b3cf..967eaaeacd75 100644
    --- a/tools/testing/selftests/kvm/include/kvm_util_base.h
    +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h
    @@ -776,10 +776,6 @@ vm_adjust_num_guest_pages(enum vm_guest_mode mode, unsigned int num_guest_pages)
    return n;
    }

    -struct kvm_userspace_memory_region *
    -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start,
    - uint64_t end);
    -
    #define sync_global_to_guest(vm, g) ({ \
    typeof(g) *_p = addr_gva2hva(vm, (vm_vaddr_t)&(g)); \
    memcpy(_p, &(g), sizeof(g)); \
    diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
    index 7a8af1821f5d..f09295d56c23 100644
    --- a/tools/testing/selftests/kvm/lib/kvm_util.c
    +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
    @@ -590,35 +590,6 @@ userspace_mem_region_find(struct kvm_vm *vm, uint64_t start, uint64_t end)
    return NULL;
    }

    -/*
    - * KVM Userspace Memory Region Find
    - *
    - * Input Args:
    - * vm - Virtual Machine
    - * start - Starting VM physical address
    - * end - Ending VM physical address, inclusive.
    - *
    - * Output Args: None
    - *
    - * Return:
    - * Pointer to overlapping region, NULL if no such region.
    - *
    - * Public interface to userspace_mem_region_find. Allows tests to look up
    - * the memslot datastructure for a given range of guest physical memory.
    - */
    -struct kvm_userspace_memory_region *
    -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start,
    - uint64_t end)
    -{
    - struct userspace_mem_region *region;
    -
    - region = userspace_mem_region_find(vm, start, end);
    - if (!region)
    - return NULL;
    -
    - return &region->region;
    -}
    -
    __weak void vcpu_arch_free(struct kvm_vcpu *vcpu)
    {

    --
    2.42.0.820.g83a721a137-goog
    \
     
     \ /
      Last update: 2023-10-27 20:26    [W:2.406 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site