Messages in this thread | | | Date | Thu, 26 Oct 2023 23:14:25 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v10 1/2] lib/bitmap: add bitmap_{read,write}() |
| |
On Thu, Oct 26, 2023 at 04:48:46PM +0200, Alexander Potapenko wrote:
...
> > > +static inline void bitmap_write(unsigned long *map, > > > + unsigned long value, > > > + unsigned long start, unsigned long nbits) > > > > While noticing strange indentation (you have space for the parameter on > > the previous line, > > I believe I do not, maybe that's something on your side? > There are tabs in the source, and in the original email.
I meant that you can use 2 lines instead of 3:
static inline void bitmap_write(unsigned long *map, unsigned long value, unsigned long start, unsigned long nbits)
> > I realized that this is a counter-intuitive interface. > > Can you actually make value the last parameter? > > It is consistent with bitmap_set_value8(map, value, start), and in all > the functions above @nbits is the last parameter.
Oh, then I leave this to Yury.
-- With Best Regards, Andy Shevchenko
| |