Messages in this thread | | | Date | Thu, 26 Oct 2023 22:08:19 +0200 | Subject | Re: [PATCH v2 2/5] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages | From | Konrad Dybcio <> |
| |
On 10/26/23 17:50, Bryan O'Donoghue wrote: > Right now we use the top-level camss structure to provide pointers via > VFE id index back to genpd linkages. > > In effect this hard-codes VFE indexes to power-domain indexes in the > dtsi and mandates a very particular ordering of power domains in the > dtsi, which bears no relationship to a real hardware dependency. > > As a first step to rationalising the VFE power-domain code and breaking > the magic indexing in dtsi use per-VFE pointers to genpd linkages. > > The top-level index in msm_vfe_subdev_init is still used to attain the > initial so no functional or logical change arises from this change. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + if (vfe->id >= camss->res->vfe_num) > return 0; P.S. this seems better suited for some warning, I think
| |