lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] ethtool: Add ethtool_puts()
From
Date
On Thu, 2023-10-26 at 10:49 -0700, Kees Cook wrote:
> On Thu, Oct 26, 2023 at 09:33:17AM -0700, Joe Perches wrote:
> > On Thu, 2023-10-26 at 08:47 -0700, Kees Cook wrote:
> > > On Wed, Oct 25, 2023 at 11:40:31PM +0000, Justin Stitt wrote:
> > > > @replace_2_args@
> > > > identifier BUF;
> > > > expression VAR;
> > > > @@
> > > >
> > > > - ethtool_sprintf
> > > > + ethtool_puts
> > > > (&BUF, VAR)
> > >
> > > I think cocci will do a better job at line folding if we adjust this
> > > rule like I had to adjust the next rule: completely remove and re-add
> > > the arguments:
> > >
> > > - ethtool_sprintf(&BUF, VAR)
> > > + ethtool_puts(&BUF, VAR)
> > >
> > > Then I think the handful of weird line wraps in the treewide patch will
> > > go away.
> > >
> >
> > Perhaps this, but i believe spatch needs
> > --max-width=80
> > to fill all 80 columns
>
> Ah, yeah. Default is 78. Current coding style max is 100... I'll adjust
> my local wrappers.

Coding style max is still 80 with exceptions allowed to 100
not a generic use of 100.


\
 
 \ /
  Last update: 2023-10-26 19:58    [W:0.242 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site