Messages in this thread | | | From | Andrey Konovalov <> | Date | Thu, 26 Oct 2023 18:36:42 +0200 | Subject | Re: [PATCH 3/3] usb: raw-gadget: report suspend, resume, reset, and disconnect events |
| |
On Thu, Oct 26, 2023 at 4:24 PM <andrey.konovalov@linux.dev> wrote: > > diff --git a/drivers/usb/gadget/legacy/raw_gadget.c b/drivers/usb/gadget/legacy/raw_gadget.c > index daac1f078516..ee712e6570b4 100644 > --- a/drivers/usb/gadget/legacy/raw_gadget.c > +++ b/drivers/usb/gadget/legacy/raw_gadget.c > @@ -65,8 +65,9 @@ static int raw_event_queue_add(struct raw_event_queue *queue, > struct usb_raw_event *event; > > spin_lock_irqsave(&queue->lock, flags); > - if (WARN_ON(queue->size >= RAW_EVENT_QUEUE_SIZE)) { > + if (queue->size >= RAW_EVENT_QUEUE_SIZE) { > spin_unlock_irqrestore(&queue->lock, flags); > + dev_err(&gadget->dev, "event queue overflown\n");
This is wrong, no reference to gadget->dev here. Will fix in v2 or send a fix up.
| |