lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] usb: raw-gadget: report suspend, resume, reset, and disconnect events
On Thu, Oct 26, 2023 at 4:24 PM <andrey.konovalov@linux.dev> wrote:
>
> diff --git a/drivers/usb/gadget/legacy/raw_gadget.c b/drivers/usb/gadget/legacy/raw_gadget.c
> index daac1f078516..ee712e6570b4 100644
> --- a/drivers/usb/gadget/legacy/raw_gadget.c
> +++ b/drivers/usb/gadget/legacy/raw_gadget.c
> @@ -65,8 +65,9 @@ static int raw_event_queue_add(struct raw_event_queue *queue,
> struct usb_raw_event *event;
>
> spin_lock_irqsave(&queue->lock, flags);
> - if (WARN_ON(queue->size >= RAW_EVENT_QUEUE_SIZE)) {
> + if (queue->size >= RAW_EVENT_QUEUE_SIZE) {
> spin_unlock_irqrestore(&queue->lock, flags);
> + dev_err(&gadget->dev, "event queue overflown\n");

This is wrong, no reference to gadget->dev here. Will fix in v2 or
send a fix up.

\
 
 \ /
  Last update: 2023-10-26 18:37    [W:0.338 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site