Messages in this thread | | | Date | Thu, 26 Oct 2023 13:32:38 +0800 | From | Leo Yan <> | Subject | Re: [PATCH] perf tests: test_arm_coresight: Simplify source iteration |
| |
On Mon, Oct 23, 2023 at 02:15:49PM +0100, James Clark wrote: > There are two reasons to do this, firstly there is a shellcheck warning > in cs_etm_dev_name(), which can be completely deleted. And secondly the > current iteration method doesn't support systems with both ETE and ETM > because it picks one or the other. There isn't a known system with this > configuration, but it could happen in the future. > > Iterating over all the sources for each CPU can be done by going through > /sys/bus/event_source/devices/cs_etm/cpu* and following the symlink back > to the Coresight device in /sys/bus/coresight/devices. This will work > whether the device is ETE, ETM or any future name, and is much simpler > and doesn't require any hard coded version numbers > > Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com> > Signed-off-by: James Clark <james.clark@arm.com>
Looks good to me. And I did a test for it:
Tested-by: Leo Yan <leo.yan@linaro.org>
| |