Messages in this thread | | | Date | Thu, 26 Oct 2023 16:18:45 +0200 | From | Théo Lebrun <> | Subject | Re: [PATCH 6/6] tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options |
| |
Hello,
On Thu Oct 26, 2023 at 3:48 PM CEST, Linus Walleij wrote: > On Thu, Oct 26, 2023 at 12:41 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote: > > > pl011_console_get_options() gets called to retrieve currently configured > > options from the registers. Previously, LCRH_TX.WLEN was being parsed > > as either 7 or 8 (fallback). Hardware supports values from 5 to 8 > > inclusive, which pl011_set_termios() exploits for example. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > With Ilpo's comment fixed: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
It's been fixed locally. Thank you for your review Linus!
Regards,
-- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |