lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v5 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver
    Hi Sakari,

    On Thu, Oct 26, 2023 at 11:11:53AM +0000, Sakari Ailus wrote:
    > On Tue, Oct 10, 2023 at 10:24:03AM +0200, Alain Volmat wrote:
    > > From: Hugues Fruchet <hugues.fruchet@foss.st.com>
    > >
    > > This V4L2 subdev driver enables Digital Camera Memory Interface
    > > Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
    > >
    > > Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
    > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
    > > ---
    > > drivers/media/platform/st/stm32/Kconfig | 15 +
    > > drivers/media/platform/st/stm32/Makefile | 1 +
    > > .../platform/st/stm32/stm32-dcmipp/Makefile | 4 +
    > > .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 916 ++++++++++++++++++
    > > .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 555 +++++++++++
    > > .../st/stm32/stm32-dcmipp/dcmipp-common.c | 106 ++
    > > .../st/stm32/stm32-dcmipp/dcmipp-common.h | 216 +++++
    > > .../st/stm32/stm32-dcmipp/dcmipp-core.c | 603 ++++++++++++
    > > .../st/stm32/stm32-dcmipp/dcmipp-parallel.c | 441 +++++++++
    > > 9 files changed, 2857 insertions(+)
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/Makefile
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.c
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
    > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c

    [snip]

    > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
    > > new file mode 100644
    > > index 000000000000..4f784c5791e7
    > > --- /dev/null
    > > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
    > > @@ -0,0 +1,916 @@
    [snip]

    > > +static const struct dcmipp_bytecap_pix_map *
    > > +dcmipp_bytecap_pix_map_by_pixelformat(u32 pixelformat)
    > > +{
    > > + unsigned int i;
    > > +
    > > + for (i = 0; i < ARRAY_SIZE(dcmipp_bytecap_pix_map_list); i++) {
    >
    > No need for braces. Up to you.

    For what it's worth, I usually ask for braces in my reviews for these
    kind of cases :-)

    > > + if (dcmipp_bytecap_pix_map_list[i].pixelformat == pixelformat)
    > > + return &dcmipp_bytecap_pix_map_list[i];
    > > + }
    > > +
    > > + return NULL;
    > > +}

    [snip]

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2023-10-26 13:36    [W:8.835 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site