Messages in this thread | | | Date | Wed, 25 Oct 2023 22:01:28 -0700 | Subject | Re: [PATCH v2] hwmon: (asus-ec-sensors) add ROG Crosshair X670E Gene. | From | Guenter Roeck <> |
| |
On 10/25/23 21:46, Ellie Hermaszewska wrote: > On 10/26/23 03:35, Guenter Roeck wrote: > > This is not an acceptable commit description. > > This is not acceptable feedback. > > I am unable to accept it because it is not clear to me what you think > should be changed. > > Is it because I misplaced the message to Eugene? Is it because of the > Greek characters? Is is not descriptive enough of the change, or in the > wrong tense, or has incorrect punctuation? Do I need to include my > testing methodology? > > If it's only something minor, then please also feel free to correct it > yourself before applying. If you can't or it's not something minor, > then please let me know what ought to change and I can try to correct it. > > If you don't let me know, then I will have to guess and possibly waste everyone's time further. >
Please consider reading and following the directions in Documentation/process/submitting-patches.rst.
Thanks, Guenter
| |