Messages in this thread | | | Date | Thu, 26 Oct 2023 15:44:40 +0530 | From | Raju Lakkaraju <> | Subject | Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get state for XPCS drivers |
| |
Hi Russell King,
Thank you for review the patch.
The 10/26/2023 10:01, Russell King (Oracle) wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Oct 26, 2023 at 11:13:05AM +0530, Raju Lakkaraju wrote: > > + sts = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_STS); > > + > > + state->link = !!(sts & DW_VR_MII_MMD_STS_LINK_STS); > > + if (!state->link) { > > + state->speed = SPEED_UNKNOWN; > > + state->pause = MLO_PAUSE_NONE; > > + state->duplex = DUPLEX_UNKNOWN; > > + return 0; > > + } > > You don't need this. If autoneg is enabled then these are initialised > prior to calling this by phylink using: > > state->speed = SPEED_UNKNOWN; > state->duplex = DUPLEX_UNKNOWN; > state->pause = MLO_PAUSE_NONE; >
Ok. I will remove the change.
Thanks, Raju
> or if not using autoneg: > > state->speed = pl->link_config.speed; > state->duplex = pl->link_config.duplex; > state->pause = pl->link_config.pause; > > so you don't need to touch them if the link is down. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
-- -------- Thanks, Raju
| |