lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/3] serial: core: Update uart_poll_timeout() function to return unsigned long
From
On 26. 10. 23, 11:24, Ilpo Järvinen wrote:
> On Thu, 26 Oct 2023, Jiri Slaby wrote:
>
>> On 25. 10. 23, 16:26, Vamshi Gajjela wrote:
>>> From: VAMSHI GAJJELA <vamshigajjela@google.com>
>>>
>>> The function uart_fifo_timeout() returns an unsigned long value, which is
>>> the number of jiffies. Therefore, the function uart_poll_timeout() has been
>>> modified to use an unsigned long type for timeout values instead of an int
>>> and to avoid truncation.
>>
>> Hi,
>>
>> there is no truncation possible, right?
>
> That's very likely true (I didn't run the calculations), thus it's correct
> to not have Fixes tag.

Good. I would remove that "and to avoid truncation" completely from the
commit log. I would only say that we are getting things consistent.

"avoid truncation" can lead to -> we should backport it to stable. And
neither is true.

> It's more about having consistent typing since
> we're talking about jiffies, so unsigned long as usual.

Yeah and that's of course fine by me.

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2023-10-26 11:51    [W:0.064 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site