Messages in this thread | | | Date | Thu, 26 Oct 2023 11:42:45 +0200 | Subject | Re: [PATCH iwl-next 1/2] i40e: Remove VF MAC types | From | Wojciech Drewek <> |
| |
On 25.10.2023 19:44, Jacob Keller wrote: > > > On 10/25/2023 7:39 AM, Ivan Vecera wrote: >> >> >> On 25. 10. 23 12:48, Wojciech Drewek wrote: >>> >>> On 25.10.2023 12:33, Ivan Vecera wrote: >>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or >>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify >>>> i40e_adminq_init_regs() and remove enums for these VF MAC types. >>>> >>>> Signed-off-by: Ivan Vecera<ivecera@redhat.com> >>>> --- >>>> drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++++++------------- >>>> drivers/net/ethernet/intel/i40e/i40e_type.h | 8 ----- >>>> 2 files changed, 10 insertions(+), 31 deletions(-) >>>> >>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> index 29fc46abf690..896c43905309 100644 >>>> --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c >>>> @@ -17,29 +17,16 @@ static void i40e_resume_aq(struct i40e_hw *hw); >>>> static void i40e_adminq_init_regs(struct i40e_hw *hw) >>>> { >>>> /* set head and tail registers in our local struct */ >>>> - if (i40e_is_vf(hw)) { >>>> - hw->aq.asq.tail = I40E_VF_ATQT1; >>>> - hw->aq.asq.head = I40E_VF_ATQH1; >>>> - hw->aq.asq.len = I40E_VF_ATQLEN1; >>>> - hw->aq.asq.bal = I40E_VF_ATQBAL1; >>>> - hw->aq.asq.bah = I40E_VF_ATQBAH1; >>>> - hw->aq.arq.tail = I40E_VF_ARQT1; >>>> - hw->aq.arq.head = I40E_VF_ARQH1; >>>> - hw->aq.arq.len = I40E_VF_ARQLEN1; >>>> - hw->aq.arq.bal = I40E_VF_ARQBAL1; >>>> - hw->aq.arq.bah = I40E_VF_ARQBAH1; >>> What about removing those I40E_VF_* defines? >>> This is their only usage here, right? >> >> Yes, do you want to remove them in this patch? Or follow-up is sufficient? >> >> Ivan >> >> > > I'm fine with a follow up.
Me too
> > Thanks, > Jake
| |