Messages in this thread | | | Date | Thu, 26 Oct 2023 10:55:33 +0300 | Subject | Re: [PATCH V2] nvmem: brcm_nvram: store a copy of NVRAM content | From | Arınç ÜNAL <> |
| |
On 26.10.2023 10:34, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This driver uses MMIO access for reading NVRAM from a flash device. > Underneath there is a flash controller that reads data and provides > mapping window. > > Using MMIO interface affects controller configuration and may break real > controller driver. It was reported by multiple users of devices with > NVRAM stored on NAND. > > Modify driver to read & cache NVRAM content during init and use that > copy to provide NVMEM data when requested. On NAND flashes due to their > alignment NVRAM partitions can be quite big (1 MiB and more) while > actual NVRAM content stays quite small (usually 16 to 32 KiB). To avoid > allocating so much memory check for actual data length. > > Link: https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@mail.gmail.com/ > Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing Broadcom's NVRAM") > Cc: Arınç ÜNAL <arinc.unal@arinc9.com> > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Scott Branden <scott.branden@broadcom.com> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Arınç
| |