Messages in this thread | | | From | Huacai Chen <> | Date | Fri, 27 Oct 2023 09:40:09 +0800 | Subject | Re: [PATCH 2/3] LoongArch: Add RSEQ_SIG break code definition |
| |
Hi, Mathieu,
On Fri, Oct 27, 2023 at 2:16 AM Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote: > > On 2023-10-26 07:44, Huang Pei wrote: > > Signed-off-by: Huang Pei <huangpei@loongson.cn> > > --- > > arch/loongarch/include/uapi/asm/break.h | 2 ++ > > Why is this part of the uapi ? None of the other architecture has this > as part of uapi. It's only defined in the rseq selftest arch-specific > header file. From my point of view, it makes sense to list the dedicated break code in UAPI. It is harmless and can avoid potential conflict in future.
Huacai
> > Thanks, > > Mathieu > > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/loongarch/include/uapi/asm/break.h b/arch/loongarch/include/uapi/asm/break.h > > index bb9b82ba59f2..e0fcfc304834 100644 > > --- a/arch/loongarch/include/uapi/asm/break.h > > +++ b/arch/loongarch/include/uapi/asm/break.h > > @@ -20,4 +20,6 @@ > > #define BRK_UPROBE_BP 12 /* See <asm/uprobes.h> */ > > #define BRK_UPROBE_XOLBP 13 /* See <asm/uprobes.h> */ > > > > +#define BRK_RSEQ_SIG 16 /* See rseq */ > > + > > #endif /* __UAPI_ASM_BREAK_H */ > > -- > Mathieu Desnoyers > EfficiOS Inc. > https://www.efficios.com > >
| |