lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 28/39] timekeeping: Fix a circular include dependency
    Date
    On Thu, Oct 26 2023 at 18:33, Suren Baghdasaryan wrote:
    > On Wed, Oct 25, 2023 at 5:33 PM Thomas Gleixner <tglx@linutronix.de> wrote:
    >> > This avoids a circular header dependency in an upcoming patch by only
    >> > making hrtimer.h depend on percpu-defs.h
    >>
    >> What's the actual dependency problem?
    >
    > Sorry for the delay.
    > When we instrument per-cpu allocations in [1] we need to include
    > sched.h in percpu.h to be able to use alloc_tag_save(). sched.h

    Including sched.h in percpu.h is fundamentally wrong as sched.h is the
    initial place of all header recursions.

    There is a reason why a lot of funtionalitiy has been split out of
    sched.h into seperate headers over time in order to avoid that.

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2023-10-27 01:06    [W:2.265 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site