lkml.org 
[lkml]   [2023]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/4] dt-bindings: hwmon: add ti,ina238
    From
    On 25/10/2023 16:25, Conor Dooley wrote:
    > On Wed, Oct 25, 2023 at 04:18:31PM +0200, Krzysztof Kozlowski wrote:
    >> On 25/10/2023 16:11, Conor Dooley wrote:
    >>> On Wed, Oct 25, 2023 at 04:07:31PM +0200, Richard Leitner wrote:
    >>>> On Wed, Oct 25, 2023 at 03:00:01PM +0100, Conor Dooley wrote:
    >>>>> On Wed, Oct 25, 2023 at 10:34:12AM +0000, Richard Leitner wrote:
    >>>>>> The ina238 driver is available since 2021 but lacks a dt-bindings file.
    >>>>>> Therefore add the missing file now.
    >>>>>
    >>>>> Seemingly it is documented in Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
    >>>>
    >>>> Thanks for the feedback. True. So is it fine if it's left there or
    >>>> should it be removed from ti,ina2xxx.yml as this is a separate driver
    >>>> with different properties?
    >>>
    >>> Merging them would seem like the most straightforward thing to do, no?
    >>
    >> Sorry folks, I don't quite get what do you want to merge or move and
    >> why. Drivers are not related to bindings. The point is the compatible is
    >> already documented, so is anything wrong with existing documentation?
    >
    > If it was not clear, I meant merging the bindings, not the drivers. IOW,
    > adding the new compatible for the ina237 to the existing ina2xx.yaml
    > binding.

    Yes, this sounds good. Maybe ina2xx is indeed not matching all of this
    hardware (e.g. supplies, shunt resistors), but then we need to talk
    about specifics.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-10-25 16:28    [W:3.048 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site