Messages in this thread | | | Date | Wed, 25 Oct 2023 10:50:53 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH 1/4] firmware: arm_ffa: Allow FF-A initialisation even when notification fails |
| |
On Wed, Oct 25, 2023 at 09:10:11AM +0200, Jens Wiklander wrote: > On Tue, Oct 24, 2023 at 12:56 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > FF-A notifications are optional feature in the specification. Currently > > we allow to continue if the firmware reports no support for the > > notifications. However, we fail to continue and complete the FF-A > > driver initialisation if the notification setup fails for any reason. > > > > Let us allow the FF-A driver to complete the initialisation even if the > > notification fails to setup. We will just flag the error and continue > > to provide other features in the driver. > > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > drivers/firmware/arm_ffa/driver.c | 21 +++++++++------------ > > 1 file changed, 9 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > > index 07b72c679247..b4ba52d674e5 100644 > > --- a/drivers/firmware/arm_ffa/driver.c > > +++ b/drivers/firmware/arm_ffa/driver.c [..] > > @@ -1426,10 +1426,11 @@ static int ffa_notifications_setup(void) > > ret = ffa_sched_recv_cb_update(drv_info->vm_id, ffa_self_notif_handle, > > drv_info, true); > > if (!ret) > > - return ret; > > + return; > > cleanup: > > + pr_info("Notification setup failed %d, not enabled\n", ret); > > ffa_notifications_cleanup(); > > - return ret; > > + return; > > This return is redundant. >
Thanks, will fix it.
-- Regards, Sudeep
| |